Display tags on the Unit page in Studio (feature-flagged) - Take 2 [FC-0036] by ChrisChV · Pull Request #33761 · openedx/openedx-platform

ChrisChV · 2023-11-21T14:45:57Z

Description

This adds:

a new container subview to show the list of tags of a unit.
the "Manage tags" menu item on the component menu.
Both are under the new_studio_mfe.use_tagging_taxonomy_list_page flag.

Supporting information

Internal ticket: FAL-3527.
Closes [Tagging] Access unit/component tags from the Unit page modular-learning#120
This fixes a deployment issue of feat: Tag List on Unit page [FC-0036] #33645 (comment)

Testing instructions

Turn on the new_studio_mfe.use_tagging_taxonomy_list_page flag on studio.
Run taxonomy-sample-data script to create sample data.
On lms shell run paver update_assets. You need to clear the cache of your browser or use an incognito session
Make sure you have the frontend-app-course-authoring repo cloned and checkout the branch of this PR [FC-0036] feat: Add ContentTagsDrawer widget frontend-app-authoring#654
Go to a new created unit and check the tag list.
Click on "Manage tags" and check that opens the drawer.
Open the menu of a component and click on "Manage tags". Check that opens the drawer
Turn off the new_studio_mfe.use_tagging_taxonomy_list_page flag on studio.
Return to the unit page and verify that the tag list and the "Manage tags" menu item not shown

Additional info

Figma discussion on expanding the children of a taxonomy

openedx-webhooks · 2023-11-21T14:46:02Z

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

open-craft-grove · 2023-11-21T15:02:05Z

Sandbox deploy request received. Deployment will start soon.

open-craft-grove · 2023-11-21T15:06:14Z

Sandbox deployment started.

ChrisChV · 2023-11-21T15:58:52Z

@bradenmacdonald This is ready. The fix is on 507eb51 CC @rgraber

open-craft-grove · 2023-11-21T16:00:42Z

Sandbox update request received. Deployment will start soon.

open-craft-grove · 2023-11-21T16:11:39Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33761-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33761-139931.staging.do.opencraft.hosting

open-craft-grove · 2023-11-21T16:11:48Z

Sandbox deployment started.

open-craft-grove · 2023-11-21T16:44:03Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33761-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33761-139931.staging.do.opencraft.hosting

bradenmacdonald

👍

I tested this: quick smoke test in Studio
I read through the code - same as prior PR with minor fix for trailing comma issue
I checked for accessibility issues
Includes documentation

openedx-webhooks · 2023-11-21T20:12:21Z

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

open-craft-grove · 2023-11-21T20:15:35Z

Sandbox update request received. Deployment will start soon.

edx-pipeline-bot · 2023-11-21T21:34:04Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2023-11-21T22:49:28Z

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot · 2023-11-21T22:57:22Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2023-11-21T23:17:43Z

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot · 2023-11-21T23:17:43Z

2U Release Notice: This PR has been deployed to the edX production environment.

…e 2 (openedx#33761)

ChrisChV added 24 commits November 1, 2023 17:44

feat: Tag List component structure

4a95e8d

feat: Build view to pass tags to UI

d8e327c

feat: Building Tag list component on unit page

e36cb84

refactor: Extract tag list as a separated component

b383efe

feat: Render tag children

a9f2afc

feat: Manage tags button added on component menu

e19ff55

chore: Lint

7305ed7

style: Nits

d79cf97

style: Adding comments in get_unit_tags

b423507

Merge branch 'master' into chris/FAL-3527-tags-on-unit-page

3db38e8

feat: Extract open and close tagging drawer to utility functions

b96fd33

feat: Open manage tag drawer

a005b34

Merge branch 'master' into chris/FAL-3527-tags-on-unit-page

694d164

fix: Bug with multiple children on the same parent tag

6d70b80

fix: caret up/down for children tags

91c03c1

style: Typo on comments

76232ba

style: Nits on UI

7aa790d

Merge branch 'master' into chris/FAL-3527-tags-on-unit-page

f19b1e8

style: Nit on open taxonomy and tag

aa12f5c

feat: Add a11y support to tag list component

29f3b9c

style: Nit

d3c7603

Merge branch 'master' into chris/FAL-3527-tags-on-unit-page

aade38f

fix: Delete problematic trailing comma

507eb51

chore: Fix merge conflicts

5c0b59b

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2023

chore: Nit

321c6a1

bradenmacdonald approved these changes Nov 21, 2023

View reviewed changes

bradenmacdonald changed the title ~~Chris/fal 3527 tags on unit page~~ Display tags on the Unit page in Studio (feature-flagged) - Take 2 [FC-0036] Nov 21, 2023

bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Nov 21, 2023

bradenmacdonald merged commit f72710e into openedx:master Nov 21, 2023

bradenmacdonald deleted the chris/FAL-3527-tags-on-unit-page branch November 21, 2023 20:12

andrey-canon mentioned this pull request May 8, 2024

feat: Display tags on the Unit page in Studio (feature-flagged) - Tak… nelc/edx-platform#25

Merged

andrey-canon pushed a commit to nelc/edx-platform that referenced this pull request May 15, 2024

feat: Display tags on the Unit page in Studio (feature-flagged) - Tak…

9d0424c

…e 2 (openedx#33761)

Conversation

ChrisChV commented Nov 21, 2023

Description

Supporting information

Testing instructions

Additional info

Uh oh!

openedx-webhooks commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

ChrisChV commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

openedx-webhooks commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

edx-pipeline-bot commented Nov 21, 2023

Uh oh!

edx-pipeline-bot commented Nov 21, 2023

Uh oh!

edx-pipeline-bot commented Nov 21, 2023

Uh oh!

edx-pipeline-bot commented Nov 21, 2023

Uh oh!

edx-pipeline-bot commented Nov 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants